Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Niektore predmety su v zimnom aj v letnom semestri #91

Open
TomiBelan opened this issue Oct 13, 2015 · 2 comments
Open

Niektore predmety su v zimnom aj v letnom semestri #91

TomiBelan opened this issue Oct 13, 2015 · 2 comments

Comments

@TomiBelan
Copy link
Member

Niektore predmety su v oboch semestroch. To jest, v registri predmetov sa dany predmet nachadza dvakrat, v jednom riadku ma "Z" a v druhom "L". (Cize nemyslim predmety ktorych semester je "".) To je tak trochu problem.

  • V RegisterPredmetovPage pouzivame key={predmet.predmet_key}, co je skratka predmetu, a teda nie je unique pre celu tabulku. React zobrazi len jeden riadok a na konzole nadava.
  • Mozno to robi problem aj inde, napr MojePredmetyPage? Treba vsetko preskumat.
  • Ba mozno chceme zmenit samotny predmet_key. Ale asi skor nie, lebo asi su aj situacie ked to praveze chceme brat ako jeden predmet.
  • Ach jaj, preco som si nezapisal ake konkretne predmety to su? Treba najst nejaky priklad.
@tommykey
Copy link

V novej akreditácii má dINF veľa takýchto predmetov, napríklad Seminár pracoviska (FMFI.KI/3-INF-601/15) alebo Pedagogická činnosť (FMFI.KI/3-INF-803/15). Zapisujú sa štandardne v oboch semestroch naraz, a robí to teda problém aj v "Moje predmety".

@TomiBelan TomiBelan mentioned this issue Nov 28, 2017
Open
@TomiBelan
Copy link
Member Author

Fuj!

Duplikatne kluce su omnoho castejsie, ako som cakal. Skoro ziaden z nasich "jedinecnych" klucov nie je naozaj jedinecny. A ked nejake serverove volanie vrati viacere vysledky s rovnakym klucom, klient ich ticho odignoruje a ukaze len jeden.

Z vystupu skriptu https://gist.github.com/TomiBelan/742308242aab251ea0530b0b7038b4e2 som sa dozvedel:

  • get_vypisane_terminy moze vratit viackrat rovnaky termin_key. To jest, existuju viacere skusky, ktore maju presne rovnaky predmet, rovnaky datum, rovnaky cas, rovnaku miestnost aj rovnaky popis. WTF. get_prihlasene_terminy sa sprava rovnako - a podozrivo casto. Naozaj je take bezne prihlasit sa naraz na dve uplne rovnake skusky?
  • vyhladaj_predmety moze vratit viackrat rovnaky predmet_key. Priklady queries: "neuropsychológia", "Všeobecná didaktika", "fyzika zeme", "fonetika a fonologia". Stane sa aj ze maju rovnaky semester ale inu fakultu (kazda fakulta co organizuje predmet dostane samostatny riadok). Ale nie vsetko viem zreprodukovat. Videl som aj logy v ktorych AIS vratil dva doslova rovnake riadky, ale mne teraz vrati len jeden.
  • zapis_plan_vyhladaj a zapis_ponuka_vyhladaj su cele zle, vid V zapise je kazdy predmet len raz, aj ked je vo viacerych blokoch #116 (ale navyse aj semestre mozu robit problemy).
  • get_prehlad_kreditov (aka "Moje hodnotenia") moze viackrat vratit rovnaky hodn_key (t.j. v jednom akademickom roku ten isty predmet viackrat). A podobne get_hodnotenia (aka "Moje predmety") viackrat rovnaky predmet_key. Treba zistit: lisia sa vzdy iba v semestri?
  • get_priebezne_hodnotenia moze viackrat vratit rovnaky predmet_key. Ale "vdaka" bugu v PriebezneHodnoteniaPage.js (vobec nepouziva key={...}) zobrazime vsetky.
  • Aspon ze studium_key a zapisny_list_key su v poriadku.

A preto treba:

  • Zmenit votrfront, aby vzdy ukazal vsetky riadky, bez ohladu na kluc.
  • Preskumat kazdu RPC metodu, co akceptuje nejaky kluc, a kazde pouzitie get_row, ci su OK.
  • Asi predefinovat predmet_key, aby obsahoval aj semester. Zistit, ci to staci.
  • Zistit, ci existuje nejaky sposob ako rozlisovat medzi viacerymi rovnakymi skuskami.

TomiBelan added a commit that referenced this issue Dec 6, 2024
@TomiBelan
Change a few remaining key= attributes to be always unique.
07e0472 
Element lists in React must have a unique key={...} attribute. This used to be
a big problem for Votr because most tables directly used fladgejt structure
keys, which weren't always unique. It was fixed when we changed all tables to
use SortableTable, because it uses key={originalIndex} on table rows.

This commit just hardens the last few cases to really make sure they're unique.
They are very unlikely to have duplicates anyway.

Updates #91.
TomiBelan added a commit that referenced this issue Dec 6, 2024
@TomiBelan
Remove hodn_key. It is not used anymore.
5bd5624 
FWIW: adding 'semester' is not enough to make it unique. It is possible for a
given student to be enrolled in a given course multiple times, even in the same
year and semester. Usually (maybe always?) they're postgraduate courses like
"Pedagogická činnosť", "Vedecká činnosť III", "Seminár pracoviska" etc. There
are known cases of:

- two rows which only differ in hodn_datum, hodn_termin, hodn_znamka,
  hodn_znamka_popis (empty vs non-empty) (seen with semester = "" or "Z")

- two rows which only differ in hodn_datum, hodn_znamka, hodn_znamka_popis
  (different non-empty values) (hodn_termin is "R - ...", semester is "")

- two rows which only differ in hodn_datum (e.g. "09.02.20xx" vs "19.06.20xx")

- two completely equal rows (seen with semester = "" or "Z")

Fortunately, we don't need a unique row identifier for this table.

Updates #91.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TomiBelan @tommykey