Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an agument to set uncompressed #179

Open
garyvdm opened this issue Nov 16, 2020 · 1 comment
Open

Add an agument to set uncompressed #179

garyvdm opened this issue Nov 16, 2020 · 1 comment

Comments

@garyvdm
Copy link

garyvdm commented Nov 16, 2020

I'm using desync to chunk a squashfs image, and so it makes sense to use uncompressed.

I find setting up the the config file to use uncompressed very clunky. I would like it if one could set that the stores in use are uncompressed via the cli, e.g.

desync make --store=/path/to/store --uncompressed ...

I would like to try contribute a patch for this, but would like to check with you guys that you are happy with this before I start working on it?

@garyvdm garyvdm changed the title Pease add a agument to set uncompressed Add a agument to set uncompressed Nov 16, 2020
@garyvdm garyvdm changed the title Add a agument to set uncompressed Add an agument to set uncompressed Nov 16, 2020
@folbricht
Copy link
Owner

The downside of that is that it'll have to apply to all stores in the command-line. That should be fine if documented that way. And as for the option itself, would it be best to make it clear that it's a store-option and name it --store-uncompressed or similar? That's a little more extensible if anything similar is needed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants