[Search] Security: preserveHTML should be false by default #3145
Labels
tag/breaking-change
Any pull request which is waiting for a breaking change release
type/feat
Any feature requests or improvements
Milestone
The Search documentation on Security says it plainly:
https://fomantic-ui.com/modules/search.html#/security
Fomantic-UI should be safe and secure out of the box, and promote secure coding practices, as well as document them.
preserveHTML
should be set asfalse
by default. Developers should knowingly and purposefully set it to true, after they have considered the implications and made sure that the data they inject is indeed secure with strings properly escaped.This would be a breaking change, as websites may depend on the current
preserveHTML
default value. However, it should be set tofalse
, and a proper advisory (release note) given.I can prepare a PR for code and documentation if this move is agreed in principle.
The text was updated successfully, but these errors were encountered: