Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct minimum freetype requirement for Fontval. #1567

Closed
HinTak opened this issue Sep 6, 2017 · 4 comments
Closed

correct minimum freetype requirement for Fontval. #1567

HinTak opened this issue Sep 6, 2017 · 4 comments
Assignees

Comments

@HinTak
Copy link

HinTak commented Sep 6, 2017

See #1524 (comment)

The passage:

"If your vanilla system freetype is used instead, then all FontValidator tests will still be run, except for the hinting validation ones."

is wrong. A few of the table tests requires FreeType 2.6.1 minimum. That's called the "ComputeMetrics Patch".

You know you could just use the supplied binary. For the Nth time.

@felipesanches
Copy link
Collaborator

felipesanches commented Sep 6, 2017

I won't officially use the supplied binary because it lacks corresponding source code. Users can always setup their system with any build of FontValidator, of course. But that's not what I'll run on Travis for testing FontBakery, because I can't blindly trust binaries without source code.

Also, the prebuilt custom freetype in this repo (https://github.com/googlefonts/fontbakery/tree/ede92e09b96d51caf56cc01b5fd7c3554782cf0f/prebuilt/custom_freetype) was built from the tagged 2.6.4 release (which is greater than 2.6.1 ...) and the full corresponding source code for that is available here: felipesanches/freetype2@1ceb2b5

@felipesanches
Copy link
Collaborator

You say "correct minimum requirement" in the issue title. If that's wrongly stated somewhere, we can fix the info. Otherwise, this is a non-issue and thus should be closed.

@HinTak
Copy link
Author

HinTak commented Sep 6, 2017

Well, now you are asking people to trust your repo instead of mine :).

@felipesanches
Copy link
Collaborator

I can't trust code that I can't read. Please stop flooding the issue tracker.

@fonttools fonttools locked and limited conversation to collaborators Sep 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants