Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It may make sense to upstream your specs into https://github.com/kaitai-io/kaitai_struct_formats/ #23

Open
KOLANICH opened this issue Jan 24, 2021 · 3 comments

Comments

@KOLANICH
Copy link

No description provided.

@ingobecker
Copy link
Collaborator

Hey,
i started a complete rewrite of the parser using construct. The specs, as present in this repository do not correctly parse newer versions of the fileformat. If i remeber correctly, construct allows to export kaitai files. Once the parser does parse files correctly, i will try to let construct generate kaitai files and see if it makes sense to upstream them. Otherwise i might complete the existing files for upstreaming.

@KOLANICH
Copy link
Author

If i remeber correctly, construct allows to export kaitai files.

Yeah, and KSC can generate Construct files.

@ingobecker
Copy link
Collaborator

I initially tried to generate contruct code from the kaitai files. Parsing worked as expected, but generating binary files did not. Thats why i had to write code manually. I will try to clean up the changes i made so i can release a new version. Maybe i will just release the extended kaitai files i have, but it would be nice to have kaitai files, that were generated by the construct code, so its guaranteed they match with working code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants