You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been playing with this library for a little bit and what concerned me when using it was that given this code from the test example:
Serial.printf("Universe %u / %u Channels | Packet#: %u / Errors: %u / CH1: %u\n",
htons(packet.universe), // The Universe for this packet
htons(packet.property_value_count) - 1, // Start code is ignored, we're interested in dimmer data
e131.stats.num_packets, // Packet counter
e131.stats.packet_errors, // Packet error counter
packet.property_values[1]); // Dimmer data for Channel 1
the e131.stats.packet_errors kept incrementing with every packet I receive. I debugged it and it turned out that all of these errors were ERROR_NONE that were initially set here. Later there's an if statement checking if error is ERROR_IGNORE, but it doesn't exclude ERROR_NONEs.
I'll post a PR with a solution that I hope is acceptable.
The text was updated successfully, but these errors were encountered:
Hey there,
I've been playing with this library for a little bit and what concerned me when using it was that given this code from the test example:
the
e131.stats.packet_errors
kept incrementing with every packet I receive. I debugged it and it turned out that all of these errors wereERROR_NONE
that were initially set here. Later there's anif
statement checking if error isERROR_IGNORE
, but it doesn't excludeERROR_NONE
s.I'll post a PR with a solution that I hope is acceptable.
The text was updated successfully, but these errors were encountered: