Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible error in petrosian fractal dimension calculation #35

Open
kellylikesjelly opened this issue Jul 12, 2022 · 2 comments
Open

Possible error in petrosian fractal dimension calculation #35

kellylikesjelly opened this issue Jul 12, 2022 · 2 comments

Comments

@kellylikesjelly
Copy link

Hello! I think there is a bug in the last line causing an error in pfd calculation, it should be numpy.log10(n / (n+0.4*N_delta)). Pls let me know if I made a mistake. Thanks :))

Screenshot 2022-07-12 151915

@forrestbao
Copy link
Owner

What do you think it should be changed to?

@kellylikesjelly
Copy link
Author

kellylikesjelly commented Jul 25, 2022

I think it should be changed to numpy.log10(n / (n+0.4xN_delta)). because in the current code its doing np.log10((n/n)+(0.4xn_delta))--> np.log10(1+0.4xn_delta) which is not the same as the equation in the paper.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants