Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

Tiny gap between top star's lower right arm? #10

Closed
Scosh opened this issue Dec 2, 2017 · 7 comments
Closed

Tiny gap between top star's lower right arm? #10

Scosh opened this issue Dec 2, 2017 · 7 comments

Comments

@Scosh
Copy link
Collaborator

Scosh commented Dec 2, 2017

Okay … I might be going crazy from looking at things for too long, but while doing some work with different colours, I noticed that the gap where the diagonal arms of the stars should meet appear to be a different side on the right than on the left?

They are essentially minuscule … and should only be observable when zooming in ridiculously close, but when just looking at these from afar, I still felt like I noticed there was a different gap on the right side.

I did some pixel-pinching in both Inkscape using the original vectors and made a .png export to check if it was just an artefact of the software and not something that is exported.

Screenshots follow of me comparing them:

Vectors

2017-12-02-222337_1900x1129_scrot

2017-12-02-222324_1900x1129_scrot

2017-12-02-222251_1900x1129_scrot

2017-12-02-222234_1900x1129_scrot

Bitmap

2017-12-02-222410_1900x1129_scrot

2017-12-02-222356_1900x1129_scrot

The background colour seems to bleed through a tiny bit, which doesn't happen where the two lower stars meet at a 90 degree angle.

In my tests this wasn't so severe or observable with our normal FOSS-AG logo colours, but was more noticeable using different colours.

If you want to compare these for yourselves, the files, including a high-resolution .png, can be found in the current version of our design_playground repository on our Gitea.


Could this just be a concession of having diagonal lines trying to meet? Or is Inkscape not aligning things perfectly and the pixel values where they should be meeting are actually different/wrong?

Please tell me if I am actually going insane and there is nothing to worry about or see here.

@Scosh
Copy link
Collaborator Author

Scosh commented Dec 2, 2017

Na … I'm not going crazy, that gap definitely is there in the export, but it's on both sides, not just on the right:

Bitmap

2017-12-02-225120_1900x1129_scrot

@Scosh
Copy link
Collaborator Author

Scosh commented Dec 2, 2017

This isn't even completely remedied when you combine the shapes using Union, btw:

Bitmap

2017-12-02-225448_1900x1129_scrot

So we definitely need to try to fix this.

@Scosh
Copy link
Collaborator Author

Scosh commented Dec 2, 2017

The example files used in the first post can now be found at:

FOSS-AG/design_playground/src/master/social-media/website

on our Gitea.

@Scosh Scosh added this to the Finished base.ink.svg milestone Dec 4, 2017
@fes0j
Copy link
Member

fes0j commented Dec 11, 2017

I think this could be solved by applying a small border; not just rely on the "fill" part of the svg.
This might be a dirty solution.

@fes0j
Copy link
Member

fes0j commented Dec 14, 2017

Under further investigation it turns out: the vector for each point of the star varies where they should be the same.
I'll link this to issue #2, this is part of the clean up.
Though this is not enough to resolve this issue :(
Read Inkscape FAQ "There's a seam, or artifact, between adjacent objects sharing the same border, or between patterns"

@Scosh
Copy link
Collaborator Author

Scosh commented Feb 15, 2018

Please try this and commit! Let's see what it looks like.

fes0j added a commit that referenced this issue Feb 16, 2018
As in GH-10 discussed, this might be the easy fix.
The border is defined as 0.02px and has the same color as each star.
There is still a little shadow visable (even in a 4096px png) which is caused by anti-aliasing.

After closing GH-2, this topic should be revisited.
@Scosh
Copy link
Collaborator Author

Scosh commented Feb 24, 2018

Closing this for now. Seems a lot better from the machine I'm currently looking at this from. Might re-open if we want to try a different method at a later point or change something about the base design.

@Scosh Scosh closed this as completed Feb 24, 2018
@Scosh Scosh self-assigned this Feb 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants