Event Tickets Dashboard: Add an info box for the organizer and teams #482

HungNgien · 2024-12-19T03:47:56Z

Add info box "Event organizer"

When click to organizer and teams will return these views.

This PR resolves #478

Summary by Sourcery

New Features:

Add an info box to the event dashboard displaying the event organizer and their teams.

Summary by Sourcery

New Features:

Display the event organizer and their teams in an info box on the event dashboard.

sourcery-ai · 2024-12-19T03:48:00Z

Reviewer's Guide by Sourcery

This pull request implements a new info box on the event dashboard. The info box displays the event organizer and the organizer's teams. It also restyles the event dashboard to accommodate the new info box. The implementation involved modifying the dashboard structure to include the new info box and updating the styling to ensure it fits correctly within the dashboard layout.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Add an info box to display event organizer and teams.	Added a new template fragment (`fragment_info_box.html`) to render the info box content. Included the new template fragment in the main event dashboard template (`index.html`). Added the `organizer_teams` variable to the dashboard view context to provide team information to the template. Updated the dashboard view to retrieve and pass organizer teams to the template.	`src/pretix/control/templates/pretixcontrol/event/index.html` `src/pretix/control/templates/pretixcontrol/event/fragment_info_box.html` `src/pretix/control/views/dashboards.py`
Restyle event dashboard to accommodate the new info box.	Wrapped the timeline and info box sections in a `dashboard` container. Added CSS classes and styles to create a two-column layout for the info box and timeline. Adjusted the timeline styles to fit within the new layout. Added responsive design rules to handle different screen sizes. Removed unnecessary panel wrappers from the timeline template (`fragment_timeline.html`).	`src/pretix/control/templates/pretixcontrol/event/index.html` `src/pretix/control/templates/pretixcontrol/event/fragment_timeline.html` `src/pretix/static/eventyay-common/scss/custom.scss`

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#478	Add an info box showing the event organizer with a link to the organizer	✅
#478	Add links to the organizer's teams in the info box	✅

Possibly linked issues

Event Tickets Dashboard: Add an info box for the organizer and teams #478: The PR implements the info box requested by the issue, displaying the event organizer and their teams on the event dashboard.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time. You can also use
this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @HungNgien - I've reviewed your changes - here's some feedback:

Overall Comments:

Consider moving inline styles (padding-left, display) to proper CSS classes for better maintainability
The teams query request.event.organizer.teams.all might cause unnecessary database hits. Consider prefetching the teams in the view if they aren't already

Here's what I looked at during the review

🟡 General issues: 1 issue found
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

src/pretix/control/templates/pretixcontrol/event/fragment_info_box.html

sourcery-ai

Hey @HungNgien - I've reviewed your changes and they look great!

Here's what I looked at during the review

🟡 General issues: 1 issue found
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

src/pretix/control/templates/pretixcontrol/event/fragment_info_box.html

mariobehling

Please make the organizer and teams clickable. So, they can be accessed from this dashboard. Thanks

HungNgien · 2024-12-19T08:46:51Z

Please make the organizer and teams clickable. So, they can be accessed from this dashboard. Thanks

Updated

mariobehling

As you can see in the screenshot the top two boxes got changed to a gray background and the heading row is misaligned.

odkhang

look okay from my end

mariobehling

Do not change the background of the table color. Keep it like the original. See below.

sourcery-ai

Hey @HungNgien - I've reviewed your changes and they look great!

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

Add info box

5306151

sourcery-ai bot reviewed Dec 19, 2024

View reviewed changes

src/pretix/control/templates/pretixcontrol/event/fragment_info_box.html Outdated Show resolved Hide resolved

HungNgien marked this pull request as draft December 19, 2024 04:14

Remove css, add teams to context

03f731c

HungNgien marked this pull request as ready for review December 19, 2024 04:25

sourcery-ai bot reviewed Dec 19, 2024

View reviewed changes

src/pretix/control/templates/pretixcontrol/event/fragment_info_box.html Show resolved Hide resolved

mariobehling requested changes Dec 19, 2024

View reviewed changes

Add link for detail organizer and teams

50dc26b

HungNgien requested a review from odkhang December 19, 2024 08:51

mariobehling requested changes Dec 19, 2024

View reviewed changes

odkhang approved these changes Dec 19, 2024

View reviewed changes

Add custom css

131341a

mariobehling requested changes Dec 21, 2024

View reviewed changes

Change background to none

1e3c1ad

HungNgien marked this pull request as draft December 23, 2024 04:36

Add css style

e531f93

HungNgien marked this pull request as ready for review December 24, 2024 01:43

sourcery-ai bot reviewed Dec 24, 2024

View reviewed changes

mariobehling requested review from mariobehling and hongquan December 25, 2024 07:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Event Tickets Dashboard: Add an info box for the organizer and teams #482

Event Tickets Dashboard: Add an info box for the organizer and teams #482

HungNgien commented Dec 19, 2024 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Dec 19, 2024 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

sourcery-ai bot left a comment

mariobehling left a comment

HungNgien commented Dec 19, 2024

mariobehling left a comment

odkhang left a comment

mariobehling left a comment

sourcery-ai bot left a comment

Event Tickets Dashboard: Add an info box for the organizer and teams #482

Are you sure you want to change the base?

Event Tickets Dashboard: Add an info box for the organizer and teams #482

Conversation

HungNgien commented Dec 19, 2024 • edited by sourcery-ai bot Loading

Summary by Sourcery

Summary by Sourcery

sourcery-ai bot commented Dec 19, 2024 • edited Loading

Reviewer's Guide by Sourcery

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

Choose a reason for hiding this comment

sourcery-ai bot left a comment

Choose a reason for hiding this comment

mariobehling left a comment

Choose a reason for hiding this comment

HungNgien commented Dec 19, 2024

mariobehling left a comment

Choose a reason for hiding this comment

odkhang left a comment

Choose a reason for hiding this comment

mariobehling left a comment

Choose a reason for hiding this comment

sourcery-ai bot left a comment

Choose a reason for hiding this comment

HungNgien commented Dec 19, 2024 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Dec 19, 2024 •

edited

Loading