Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio in FoundationKit #21

Open
MSch opened this issue Jul 10, 2011 · 5 comments · May be fixed by #22
Open

Audio in FoundationKit #21

MSch opened this issue Jul 10, 2011 · 5 comments · May be fixed by #22
Labels

Comments

@MSch
Copy link
Contributor

MSch commented Jul 10, 2011

It seems that if you build a .framework out of FoundationKit NKAudioRecorder fails, since it depends on AudioToolbox. It works for a static library.

My understanding is that this is since frameworks have dependencies (and AudioToolbox is missing) while static libraries don't have any dependencies to begin with (the embedding app has to provide the dependencies)

Please check out my branch that adds a .framework target for Mac OS X bd6cfe2

I wasn't against the inclusion of NKAudioRecorder since I thought AudioToolbox gets pulled in by Foundation, but that has been wrong. We should therefore remove NKAudioRecorder (and move it to iOSKit/MacKit instead?)

@MSch
Copy link
Contributor Author

MSch commented Jul 10, 2011

Or is it possible to weak-link the framework? And should we do that?

@MSch
Copy link
Contributor Author

MSch commented Jul 10, 2011

I've now weakly linked the necessary Audio frameworks. See 5d67236

@eaigner
Copy link
Contributor

eaigner commented Jul 10, 2011

What's 'weak' linking? If it doesn't work, just remove it. We shouldn't sacrifice the ease-of-use for certain classes, should we?

@MSch
Copy link
Contributor Author

MSch commented Jul 12, 2011

Yeah, I +1 for removal

@myell0w
Copy link
Member

myell0w commented Sep 25, 2011

+1 for removal/moving to MacKit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants