Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update account create docs #2508

Closed
4 tasks
cptartur opened this issue Sep 24, 2024 · 0 comments · Fixed by #2517
Closed
4 tasks

Update account create docs #2508

cptartur opened this issue Sep 24, 2024 · 0 comments · Fixed by #2517
Assignees
@kkawula
Labels
documentation Improvements or additions to documentation sncast

Comments

@cptartur
Copy link
Member

cptartur commented Sep 24, 2024 •
edited
Loading

Fix and extend docs related to account create docs:

  • Fix formatting problems
  • Change the guide so it shows examples step by step, in a copy-able manner: account create, prefunding the account (link to faucet), account deploy.
  • Include screenshots from the faucet in the prefunding step
  • Add an "expert" step to show that salt and fee token can be configured (default instruction should omit these)
@cptartur cptartur converted this from a draft issue Sep 24, 2024
@github-actions github-actions bot added the new label Sep 24, 2024
@cptartur cptartur added documentation Improvements or additions to documentation sncast and removed new labels Sep 24, 2024
@kkawula kkawula mentioned this issue Sep 25, 2024
Merged
5 tasks
@cptartur cptartur moved this from In Review to In Progress in Starknet foundry Sep 30, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 15, 2024
@kkawula @cptartur
Update account create docs (#2517)
eacc4dd 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2508

## Introduced changes

<!-- A brief description of the changes -->

- Updated docs

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Artur Michałek <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkawula kkawula

Labels
documentation Improvements or additions to documentation sncast
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update account create docs foundry-rs/starknet-foundry
2 participants
@cptartur @kkawula