Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #2536

Open
franciszekjob opened this issue Sep 30, 2024 · 1 comment
Open

Improve error handling #2536

franciszekjob opened this issue Sep 30, 2024 · 1 comment
Assignees
Labels
feature New feature request/description sncast

Comments

@franciszekjob
Copy link
Collaborator

Which component is your feature related to?

Cast

Feature Request

In the scope of this issue, we should:

  • add displaying content of unknown error
  • handle other errors coming from starknet-rs, e.g. having such example in which we declare a new contract with sncast and we don't provide max-gas, we receive "Unknown RPC error", even though the real error is FeeOutOfRange coming from starknet-rs
@github-actions github-actions bot added the new label Sep 30, 2024
@cptartur cptartur added the sncast label Oct 7, 2024
@cptartur cptartur removed the new label Oct 17, 2024
@cptartur cptartur moved this from New to Backlog in Starknet foundry Oct 17, 2024
@cptartur cptartur added the feature New feature request/description label Oct 17, 2024
@cptartur
Copy link
Member

cptartur commented Nov 4, 2024

We can probably remove the whole starknet-rs to ours errors mapping or at least simplify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request/description sncast
Projects
Status: TODO
Development

No branches or pull requests

3 participants