Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'account delete' command #2539

Merged
merged 19 commits into from
Oct 8, 2024
Merged

Fix 'account delete' command #2539

merged 19 commits into from
Oct 8, 2024

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Oct 1, 2024 •
edited
Loading

Closes #2520

Introduced changes

  • Made --url argument optional

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@kkawula kkawula marked this pull request as ready for review October 1, 2024 11:24
cptartur
cptartur requested changes Oct 3, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
crates/sncast/src/starknet_commands/account/delete.rs Outdated Show resolved Hide resolved
crates/sncast/tests/e2e/account/delete.rs Outdated Show resolved Hide resolved
cptartur
cptartur approved these changes Oct 4, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
kkawula and others added 2 commits October 8, 2024 12:12
franciszekjob
franciszekjob requested changes Oct 8, 2024
View reviewed changes
crates/sncast/tests/e2e/account/delete.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
crates/sncast/tests/e2e/account/delete.rs Outdated Show resolved Hide resolved
crates/sncast/tests/e2e/account/delete.rs Outdated Show resolved Hide resolved
franciszekjob
franciszekjob approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kkawula kkawula added this pull request to the merge queue Oct 8, 2024
Merged via the queue into master with commit e2519c6 Oct 8, 2024
24 checks passed
@kkawula kkawula deleted the kkawula/2520-fix-account-delete-command branch October 8, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciszekjob franciszekjob franciszekjob approved these changes

@cptartur cptartur cptartur approved these changes

@ksew1 ksew1 Awaiting requested review from ksew1

@integraledelebesgue integraledelebesgue Awaiting requested review from integraledelebesgue

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix account delete command
3 participants
@kkawula @cptartur @franciszekjob