Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mid-encounter actor level changes don't recalculate encounter metrics (threat, xp) #16460

Open
shemetz opened this issue Sep 9, 2024 · 1 comment
Labels
bug Functionality that is not working as intended

Comments

@shemetz
Copy link
Contributor

shemetz commented Sep 9, 2024

Applying Elite or Weak to NPCs in an encounter doesn't alter the calculated threat. Those level adjustments are correctly taken into account in the calculateXP function parameters -- the problem is that clicking the Elite/Weak buttons on NPC sheets doesn't trigger recalculation of this number.

This is a problem because as a GM I sometimes wish to create improvised combat encounters and fine-tune them to be at the right threat level. This means that after adding a few enemies I try to set some of them as Elite or Weak and see how it affects the threat ranking. With this bug, I can't get immediate feedback on this, I have to e.g. remove and add them to combat again.

@shemetz shemetz changed the title Encounter metrics (threat, xp) doesn't take level adjustments into account Applying Elite/Weak level adjustments to NPCs doesn't recalculate encounter metrics (threat, xp) Sep 9, 2024
@shemetz
Copy link
Contributor Author

shemetz commented Sep 9, 2024

I imagine that the right solution to this problem would be: hook into updateActor, condition on actors that are combatants, condition on updates that change actor level. when this happens, recalculate combat XP (or clone+recreate combat object, however the system does it normally)

@stwlam stwlam added the bug Functionality that is not working as intended label Sep 13, 2024
@stwlam stwlam changed the title Applying Elite/Weak level adjustments to NPCs doesn't recalculate encounter metrics (threat, xp) Actor updates don't recalculate encounter metrics (threat, xp) Sep 20, 2024
@stwlam stwlam changed the title Actor updates don't recalculate encounter metrics (threat, xp) Mid-encounter actor level changes don't recalculate encounter metrics (threat, xp) Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality that is not working as intended
Projects
None yet
Development

No branches or pull requests

2 participants