Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for annotations #119

Closed
GregCornis opened this issue Oct 26, 2023 · 5 comments · Fixed by #123
Closed

Support for annotations #119

GregCornis opened this issue Oct 26, 2023 · 5 comments · Fixed by #123
Labels
TODO something to be done when time allows

Comments

@GregCornis
Copy link

Just wondering if the plugin supports Grafana annotations ? I do not see the "SQLite" listed in the available data sources when creating a query annotation, from the dashboard.

@fr-ser fr-ser added the TODO something to be done when time allows label Oct 26, 2023
@fr-ser
Copy link
Owner

fr-ser commented Oct 26, 2023

I must say I just never really used annotations. I'll have to see what those are and what is required to get those working.

I'll take a look and post updates here.

@eeddaann
Copy link
Contributor

Hey,
I have followed the steps on Grafana's docs and implemented them here . The default behavior looks fine - tested manually.

@fr-ser fr-ser mentioned this issue Dec 26, 2023
@fr-ser
Copy link
Owner

fr-ser commented Dec 26, 2023

Thanks a lot to @eeddaann for the annotations feature!

I created a new release with those changes https://github.com/fr-ser/grafana-sqlite-datasource/releases/tag/v3.4.0

Please have a look and see if this works as expected. I would release the new version to the official Grafana repository if I don't hear about any bugs in the following weeks

@fr-ser fr-ser reopened this Dec 26, 2023
@GregCornis
Copy link
Author

I didn't manage to test this, as 3.4.0 is not yet on Grafana Plugin Registry. I did follow the manual installation procedure but couldn't get it to work it seems. Everytime I restarted the service (i'm on MacOS), the plugin 3.3.2 reappeared. Do you know how I can test ? Actually do you even need me to test ?

@fr-ser
Copy link
Owner

fr-ser commented Jan 6, 2024

This command should do the trick:

grafana-cli --pluginUrl https://github.com/fr-ser/grafana-sqlite-datasource/releases/download/v3.4.0/frser-sqlite-datasource-3.4.0.zip plugins install frser-sqlite-datasource

If this does not work I don't know without further information what the issue might be.

While it would be nice to have someone check that the issue is resolved it is not necessary. I started the release process of the plugin now and in the near future it should be available via the Grafana plugin registry as well.

@fr-ser fr-ser closed this as completed Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO something to be done when time allows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants