Algo to give k ranked miners for store #45
+274
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shr1ftyy
requested changes
Jan 23, 2025
| # Calculate number of top, low, and random miners | ||
| num_top = int(k * top_fraction) | ||
| num_low = int(k * low_fraction) | ||
| logger.debug(f"Top: {num_top}, Low: {num_low}") |
There was a problem hiding this comment.
This log should make it obvious that we're selecting miners.
Shr1ftyy
reviewed
Jan 23, 2025
| self: Neuron, | ||
| k: int, | ||
| exclude: list[int] = None, | ||
| rank_by: str = "total_successes", |
There was a problem hiding this comment.
Update:
I think ranking based off of total_successes we should determine the ranks of the miners by their moving average scores (which is self.scores in the Validator's class).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that erasure coding provides us with a guarantee that we can recover the file even after a 30% loss of the data pieces. We can use this assign 70% of the pieces (mix of data and parity pieces) to higher ranking miners and 30% of the pieces (only data pieces) to lower ranking miners to allow them to build trust and rank in the network.
Introduces
top_miner_ratio settingCloses #3