Skip to content
This repository has been archived by the owner on Jan 10, 2019. It is now read-only.

NaN prizes and edge weights #26

Open
agitter opened this issue Jan 20, 2017 · 3 comments
Open

NaN prizes and edge weights #26

agitter opened this issue Jan 20, 2017 · 3 comments
Assignees
Labels

Comments

@agitter
Copy link
Contributor

agitter commented Jan 20, 2017

forest.py should check for NaN prizes and edge weights. I accidentally ran it with a NaN prize. It propagates the data to msgsteiner, producing output files that are technically valid but don't make sense. In my case, they ignored the specified root node.

I'll make this fix myself when time permits.

@agitter agitter self-assigned this Jan 20, 2017
@agitter
Copy link
Contributor Author

agitter commented Jan 20, 2017

And it should also check for infinite prizes, which cause similar problems.

@agitter agitter added the bug label Jan 23, 2017
@agitter
Copy link
Contributor Author

agitter commented Jan 23, 2017

Does anyone else have an opinion about the preferred forest.py behavior when we encounter NaN or infinite prizes? We could:

  1. Add a new warning that states the number of invalid prizes and continue running with the valid prizes
  2. Stop execution

I will implement 1. unless there are other opinions. It seems most consistent with the rest of our error handling.

@AmandaKedaigle
Copy link
Contributor

Yeah, I think 1 is good. There could be some kind of threshold for what percentage of prizes must be valid for it to continue, the way we handle protein name mismatches, but I don't feel strongly either way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants