Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Coverage report not sent to Coveralls #20646

Closed
madmath03 opened this issue Feb 17, 2020 · 0 comments · Fixed by #20647
Closed

[BUG] Coverage report not sent to Coveralls #20646

madmath03 opened this issue Feb 17, 2020 · 0 comments · Fixed by #20647
Labels

Comments

@madmath03
Copy link
Contributor

Description of the issue

Coverage report is not being sent to Coveralls.io during Travis-CI builds.

Same issue than frappe/frappe#9169. Since I already a fix for Frappe, I will send PR for ERPNext too, but I'm also expecting to encounter the same issue as in frappe/frappe#9304...

Context information (for bug reports)

The Root Cause is z4r/python-coveralls#73 : python-coveralls is not compatible with coverage 5.0, thus breaking the report to Coveralls.

Output of bench version
All versions impacted.

Steps to reproduce the issue

  1. Travis-CI build

Observed result

Coverage not sent to Coveralls.

Expected result

Coverage not sent to Coveralls.

Stacktrace / full error message

From travis.yml, coveralls -b apps/frappe -d ../../sites/.coverage:

Traceback (most recent call last):
  File "/home/travis/virtualenv/python2.7.14/bin/coveralls", line 11, in <module>
    sys.exit(wear())
  File "/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/coveralls/__init__.py", line 78, in wear
    from coveralls.control import coveralls
  File "/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/coveralls/control.py", line 2, in <module>
    from coveralls.report import CoverallsReporter
  File "/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/coveralls/report.py", line 6, in <module>
    from coverage.report import Reporter
ImportError: cannot import name Reporter

Additional information

N/A

@madmath03 madmath03 added the bug label Feb 17, 2020
madmath03 added a commit to Monogramm/erpnext that referenced this issue Feb 17, 2020
madmath03 added a commit to Monogramm/erpnext that referenced this issue Feb 17, 2020
madmath03 added a commit to Monogramm/erpnext that referenced this issue Feb 17, 2020
nabinhait pushed a commit that referenced this issue Feb 20, 2020
* chore(ci-coverage): Pin coveralls 4.5.4 #20646

Signed-off-by: mathieu.brunot <[email protected]>

* chore: Pin coverage

Signed-off-by: mathieu.brunot <[email protected]>
nabinhait pushed a commit that referenced this issue Feb 20, 2020
* chore(ci-coverage): Pin coveralls 4.5.4 #20646

Signed-off-by: mathieu.brunot <[email protected]>

* chore: Pin coverage

Signed-off-by: mathieu.brunot <[email protected]>
nabinhait pushed a commit that referenced this issue Feb 20, 2020
* chore(ci-coverage): Pin coveralls 4.5.4 #20646

Signed-off-by: mathieu.brunot <[email protected]>

* chore: Fix coverage

Signed-off-by: mathieu.brunot <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant