From 025717f7f52733ddff027a1e92a05e5f591fb0d6 Mon Sep 17 00:00:00 2001
From: patrick brisbin <pbrisbin@gmail.com>
Date: Tue, 20 Feb 2024 13:14:06 -0500
Subject: [PATCH] Refactor release Job

- Float `env` out to Job-level
- Add a little whitespace
- Add `name` to `stack upload` steps
- Comment why the old resolver
---
 .github/workflows/release.yml | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 4d707b6b..9d997cc8 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -17,7 +17,12 @@ jobs:
   release:
     needs: tag
     if: needs.tag.outputs.tag
+
     runs-on: ubuntu-latest
+
+    env:
+      HACKAGE_KEY: ${{ secrets.HACKAGE_UPLOAD_API_KEY }}
+
     steps:
       - uses: actions/checkout@v4
       - run: sudo apt-get install --assume-yes --no-install-recommends librdkafka-dev
@@ -26,8 +31,9 @@ jobs:
           test: false
           stack-build-arguments: --haddock --haddock-for-hackage
 
-      - run: |
-          stack --stack-yaml stack-lts-18.28.yaml upload --pvp-bounds lower .
-          stack upload --documentation .
-        env:
-          HACKAGE_KEY: ${{ secrets.HACKAGE_UPLOAD_API_KEY }}
+      # Upload using our oldest, tested resolver, to set the lowest lower bounds
+      - name: "Release to Hackage"
+        run: stack --stack-yaml stack-lts-18.28.yaml upload --pvp-bounds lower .
+
+      - name: "Upload documentation"
+        run: stack upload --documentation .