Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with hspec-junit-formatter-1.1.0.0 #43

Closed
snoyberg opened this issue Dec 8, 2021 · 8 comments
Closed

Build failure with hspec-junit-formatter-1.1.0.0 #43

snoyberg opened this issue Dec 8, 2021 · 8 comments

Comments

@snoyberg
Copy link

snoyberg commented Dec 8, 2021

[13 of 20] Compiling Freckle.App.Test.Hspec.Runner

/var/stackage/work/unpack-dir/unpacked/freckle-app-1.0.0.4-4a8b4f8964784f4048fbd2ad53adaccc053f006c44eb3673024fbe487228aaff/library/Freckle/App/Test/Hspec/Runner.hs:18:1: error:
    Could not find module ‘Test.HSpec.JUnit’
    Perhaps you meant
      Test.Hspec.JUnit (from hspec-junit-formatter-1.1.0.0)
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
18 | import Test.HSpec.JUnit (runJUnitSpec)
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
snoyberg added a commit to commercialhaskell/stackage that referenced this issue Dec 8, 2021
@pbrisbin
Copy link
Member

pbrisbin commented Dec 8, 2021

👋 we had a few hiccups with the HSpec/Hspec change that caused some quick version churn between these two packages. This was fixed in freckle-app-1.0.2.2, which works with hspec-junit-formatter newer than 1.0.3.0.

snoyberg added a commit to commercialhaskell/stackage that referenced this issue Dec 9, 2021
This reverts commit 55fbe48.

Closes freckle/freckl-app#43
@snoyberg
Copy link
Author

snoyberg commented Dec 9, 2021

Thanks!

@snoyberg snoyberg closed this as completed Dec 9, 2021
@snoyberg
Copy link
Author

Just noticed that due to commercialhaskell/stackage#6273, this doesn't resolve the issue for Stackage.

@snoyberg snoyberg reopened this Dec 10, 2021
snoyberg added a commit to commercialhaskell/stackage that referenced this issue Dec 10, 2021
@pbrisbin
Copy link
Member

Sorry, I sometimes have trouble understanding the relation between various Stackage issues. What is the reason that issue being open means this one must also be open?

@snoyberg
Copy link
Author

Since ekg isn't is Stackage, we can't include the newer version of freckle-app, which depends on it. And the older version is incompatible with hspec-junit-formatter-1.1.0.0

@pbrisbin
Copy link
Member

I see. But this only blocks us being in lts-19.x right? lts-18 won't be allowed off hspec-junit-formatter-1.0.x so everything will stay in that line?

@snoyberg
Copy link
Author

Yes, that's true.

@pbrisbin
Copy link
Member

pbrisbin commented Feb 28, 2022

My understanding of the current state of things:

  • The build failure in this Issue was addressed
  • freckle-app (and hspec-junit-formatter < 1.1) are in lts-18.x
  • freckle-app cannot be in lts-19.x because ekg has dropped out
  • ekg just needs a new release, but maintainers have gone silent, see here
  • freckle-app is now (also?) disabled because of aeson-2.0

Therefore, I think this Issue need not be open. If anything, we should have an Issue about aeson-2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants