Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6: DecoupledGcd example is not decoupled on the output side and tests fail to catch it #134

Open
sterin opened this issue Jan 25, 2021 · 0 comments

Comments

@sterin
Copy link
Contributor

sterin commented Jan 25, 2021

The example ignores the ready signal on the output side.

expectDequeueSeq fails to catch the problem because it consumes the data as soon as it is available. It tests the correctness of the data, but not whether the interface can handle backpressure.

BTW, by pure chance it is able to handle a single cycle or ready being false because the handshake takes an additional cycle after busy is set to false.

The bits remains valid because it is initially set to DontCare except for when it is assigned to (xInitial, yInitial, x). Chisel is free to just connect bits to (xInitial, yInitial, x) and it does, making the data valid for that additional cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant