Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable eyecite with vectorscan in prod (instead of using Python's re module) #3953

Closed
mlissner opened this issue Apr 8, 2024 · 2 comments · Fixed by #3976
Closed

Enable eyecite with vectorscan in prod (instead of using Python's re module) #3953

mlissner opened this issue Apr 8, 2024 · 2 comments · Fixed by #3976

Comments

@mlissner
Copy link
Member

mlissner commented Apr 8, 2024

Amazingly, in prod we're not using the CPU-optimized version of eyecite, which uses vectorscan:

https://github.com/VectorCamp/vectorscan

We should do that. It's faster! It saves energy! Let's do that. I think we just need to enable/install a dependency, but the eyecite docs should have the details.

@mlissner mlissner moved this to Main Backlog in @erosendo's backlog Apr 8, 2024
@mlissner
Copy link
Member Author

mlissner commented Apr 9, 2024

Over in freelawproject/eyecite#177, we bumped to hyperscan 0.7.7, which switches to vectorscan and thereby enables support for ARM processors. That might be enough to make vectorscan work, but I'd like to be sure we're using it.

@mlissner
Copy link
Member Author

mlissner commented Apr 9, 2024

Yeah, looks like we need to enable the correct tokenizer: https://github.com/freelawproject/eyecite/?tab=readme-ov-file#tokenizers

@ERosendo ERosendo moved this from Main Backlog to ✍🏻In Progress in @erosendo's backlog Apr 16, 2024
@ERosendo ERosendo linked a pull request Apr 16, 2024 that will close this issue
@ERosendo ERosendo moved this from ✍🏻In Progress to 🔎In Review in @erosendo's backlog Apr 16, 2024
@github-project-automation github-project-automation bot moved this from 🔎In Review to Done in @erosendo's backlog Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant