Update all dependencies. #2757
Open
Update all dependencies. #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you check all the release notes for these? I wouldn't want to do this without doing so. |
Not in detail yet. |
ttys0dev
force-pushed
the
update-all
branch
2 times, most recently
from
5038f89 to
7153dbd
Compare
ttys0dev
commented
May 23, 2023
| @@ -58,7 +58,6 @@ def _create_browser() -> webdriver.Chrome: | |||
| if settings.SELENIUM_HEADLESS is True: | |||
| options.add_argument("headless") | |||
| options.add_argument("silent") | |||
| options.add_experimental_option("w3c", False) | |||
There was a problem hiding this comment.
This option isn't supported in the latest selenium, not sure why it was needed but seems we can remove it now, the commit in 65013fd adding this flag just says:
Adds the w3c False flag, which solves some dumb Selenium thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets see if this helps, seems we have a ton of outdated dependencies.