Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase MaxSchedulerPerBlock for Benchmarking #840

Closed
asiniscalchi opened this issue Oct 23, 2024 · 4 comments · Fixed by #858
Closed

Increase MaxSchedulerPerBlock for Benchmarking #840

asiniscalchi opened this issue Oct 23, 2024 · 4 comments · Fixed by #858

Comments

@asiniscalchi
Copy link
Member

asiniscalchi commented Oct 23, 2024 •
edited
Loading

As a developer, I want to increase the MaxSchedulerPerBlock parameter when running benchmarks to align with best practices used in the polkadot-sdk.

"We recommend increasing the MaxSchedulerPerBlock parameter when running benchmarks, as done in the polkadot-sdk default node runtime."
@luispdm
Copy link
Contributor

luispdm commented Oct 29, 2024

Polkadot-sdk example -> https://github.com/paritytech/polkadot-sdk/blob/master/substrate/bin/node/runtime/src/lib.rs#L457-L460

@luispdm luispdm self-assigned this Oct 29, 2024
@luispdm luispdm linked a pull request Oct 29, 2024 that will close this issue
Set MaxScheduledPerBlock for benchmark purposes #858
Merged
@luispdm luispdm removed their assignment Oct 29, 2024
@ccubu ccubu self-assigned this Oct 30, 2024
@ccubu
Copy link
Contributor

ccubu commented Oct 31, 2024

I think this error might not be directly caused by the change in this PR but I am unable to run all the benchmarks.

Pallet_democracy::veto_external fails with a Bad origin error as can be seen on the logs attached.

benchmarking_errors.txt

@luispdm
Copy link
Contributor

luispdm commented Oct 31, 2024

It's unrelated; I just tested on a branch that doesn't have this change

@ccubu
Copy link
Contributor

ccubu commented Nov 4, 2024

Created this task to fix the benchmark error to tackle in the future https://github.com/orgs/freeverseio/projects/3/views/7?filterQuery=no%3Astatus+no%3Asprint+benchma&pane=issue&itemId=85837117

@ccubu ccubu moved this from QA to Done in LAOS Nov 4, 2024
@ccubu ccubu removed their assignment Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
LAOS
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set MaxScheduledPerBlock for benchmark purposes freeverseio/laos
3 participants
@asiniscalchi @luispdm @ccubu