-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rest service for ip registration #37
Comments
Surely it's possible. What would be your preferred authentication method? Token-based? Do you really want to rely on the email-confirmation method? For an API I don't know if it is the most useable and convient way to go with... |
mhh.. I did'nt thought about authentication yet. I guess we could skip the mail, |
The user should receive a mail with all the data. |
I think the email verification is the easiest way. We don't want users to create accounts so I don't see an alternative. Furthermore: why should we switch to a different authentication mechanism? I see this as another way to access the IP registry functionality that already exists. So I can imagine something like:
Response: 200 for success without body. Clicking the verification link should work as before.
|
Well I like token based authentication methods for external apps to prevent massive spam registrations. Nothing fancy we could just add tokens for enabled apps in our config file. |
Furthermore I would prefer to use lists for subnets and get rid of the count param like the following:
If |
May I suggest 201 Created or 202 Accepted instead? (yes I know, nitpicking. But I <3 proper status codes ;) ) |
Absolutely right! 😄 http://httpstatus.es/201 |
I nominate 204 for the election process. |
preliminary API documentation: https://pad.freifunk.net/p/berlin-wizard :) |
for the new wizard we would like to register IPs during configuration (see freifunk-berlin/firmware-wizard-frontend#9)
is it possible to get a service for ip registration with the following spec?
method: reserveIPs
params: routername, mail, meships count, subnet (yes/no), v6prefix) that sends a mail with an confirmation key
function: reserve IPs and send mail to user with confirmation key
return: success / failure
method: confirmIPs
params: confirmation key, email
function: register ips for the user, send success mail
return: success (json with IPs) / failure
The text was updated successfully, but these errors were encountered: