autoupdater: if selected branch is not in selectbox, show empty selection

[rubo77]

If a node has a value for branch in the config that is not in the list of autoupdater mirrors from site.conf, then the selectbox is mislieadingly showing the first option as selected.

In that case, it should either show an empty selection or better, show the stored selection as new added option to the selectbox.

[neocturne]

Hmm, I think it would be a better idea to ensure that the default branch always exists. That way, the broken configuration you mention can not occur (unless you manually break it using uci).

[rubo77]

problem is, that there is no warning, that something is wrong. and especially, if the first entry is the same entry as the one, you expect, then you never notice, because the page in config mode shows something, that is not there.

there should be a warning like

"Warning! The node is on autoupdater branch 'XY' which is not in the list"

Or better: during the build process, you should stop with an error if you try to build on a branch, that is not listed in the mirrors list in site.conf.

It is easy to prevent this from happening, if you call the build command by hand, but there are several steppingstones:

• a typo like make GLUON_BRANCH=experimentell statt experimental
• if you use a CI with a build script, that generates the commands

Also, you will see, if a branch is abandoned, and your node still is on an old branch that doesn't exist any more

[rotanid]

as we never support custom modifications, the change in config mode shouldn't be necessary.

i'm not sure, if your case of a typo during build should be checked by the build scripts...

[rubo77]

I just had no typo, our problem was, that I noticed, that our beta firmware "rc" had "release-candidate" stored as branch in the config, which is not in the list. Created by our "intelligent" ci