Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rate parsing shouldn't use powers of 2 #59

Open
edwintorok opened this issue Mar 24, 2016 · 1 comment
Open

rate parsing shouldn't use powers of 2 #59

edwintorok opened this issue Mar 24, 2016 · 1 comment

Comments

@edwintorok
Copy link

According to https://en.wikipedia.org/wiki/Binary_prefix#Data_transmission_and_clock_rates and
https://en.wikipedia.org/wiki/Gigabit_Ethernet a GbE link can transfer 1,000,000,000 bits per second,
and a 100 Mbit/s link can transfer 100,000,000 bits per second.

But you parse 1Gbps as 2^30 which doesn't seem right:
https://github.com/frenetic-lang/ocaml-topology/blob/master/lib/Network_Common.ml#L20

@jnfoster
Copy link
Member

Yup. Note that most development now happens in the main frenetic repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants