Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[f2c] Licenses not converted correctly #1

Open
Stephen-Gates opened this issue Jan 5, 2018 · 0 comments
Open

[f2c] Licenses not converted correctly #1

Stephen-Gates opened this issue Jan 5, 2018 · 0 comments
Labels

Comments

@Stephen-Gates
Copy link

Stephen-Gates commented Jan 5, 2018

See frictionlessdata/ckanext-datapackager#62

When I upload this datapackage.zip to this ckan site the licenses aren't unpacked correctly

screenshot 2017-12-06 22 19 03

@amercader suggests following algorithm when ingesting DP

  • If licenses is present check if the first item exists in the licenses registry.
  • If so, set license_id
  • If it doesn't exist in the registry, or there is more than one license, store the licenses object as an extra, so instances with the datapackager extension can handle it as they see fit. They will need to take care of keep license_id (the default field) and the licenses extra in sync.

This is good. However, it is only something one can do "inside" CKAN so it is outside of scope here. I would suggest we just convert first license.name in licenses to license_id and license.title to license_title

@roll roll added the bug label May 20, 2019
@rufuspollock rufuspollock changed the title Licenses not converted correctly [f2c] Licenses not converted correctly Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants