Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polars plugin #1662

Open
areleu opened this issue Jun 21, 2024 · 4 comments · May be fixed by #1680
Open

Add Polars plugin #1662

areleu opened this issue Jun 21, 2024 · 4 comments · May be fixed by #1680

Comments

@areleu
Copy link
Contributor

areleu commented Jun 21, 2024

Overview

Hi guys, I was wondering if you are working on supporting polars: https://pola.rs/

If not I have been working on a plugin here: https://github.com/areleu/frictionless-py/tree/polars-plugin

It is still missing some tests and I have to sort out some edge cases but let me know if you are interested on including this feature. I would find it very valuable because as of the last couple of months I have been working almost exclusively with polars and not pandas.

By the way, I have been inspiring a lot from the pandas plugin so some things may look similar, my initial approach was only copying the files and working through the error messages.

@pierrecamilleri
Copy link
Collaborator

Hello, thank you for the proposition. As far as I know, there are no plans to implement this plugin on our side for now.

In theory, we'd be happy to integrate a plugin for polars.

In practice, if we were to integrate this plugin, would you be willing to maintain it and respond to bug reports? I'm myself not familiar with polars and the time we have to allocate to maintenance is limited after all.

@areleu
Copy link
Contributor Author

areleu commented Sep 5, 2024

Hello, thank you for the proposition. As far as I know, there are no plans to implement this plugin on our side for now.

In theory, we'd be happy to integrate a plugin for polars.

In practice, if we were to integrate this plugin, would you be willing to maintain it and respond to bug reports? I'm myself not familiar with polars and the time we have to allocate to maintenance is limited after all.

I would not mind helping out with bug reports and maintenance, but I may be slow depending on the time of the year. But in general I think I can respond within a week or two.

Other option is to make the plugin its own repository, is there a proper way of doing this?

@areleu areleu linked a pull request Sep 5, 2024 that will close this issue
@pierrecamilleri
Copy link
Collaborator

Other option is to make the plugin its own repository, is there a proper way of doing this?

Great question ! I am not familiar enough with frictionless to answer. @roll, what do you think ?

@roll
Copy link
Member

roll commented Sep 16, 2024

I think the polars plugin is amazing!

Technically both in frictionless-py codebase, and as a separate codebase are quite the same, so I would say that the only difference is what way of maintenance is more convenient for developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants