-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
append()
drops custom datapackage
class
#198
Comments
I'm struggeling because
Thus creating a method for it is not as strait forward as it was for |
Something something |
@khusmann would you know how to extend base R |
I don't think there's any good way of doing this. The standard way of doing this, from what I've seen (and what @PietrH linked), is to alias/mask the method, and make the default S3 call the base implementation of the method. The problem with this, I think, is that packages that depend on frictionless-r would all have to re-import that S3 modified version of My recommendation is to instead build an API around datapackage manipulations that provides pipe-able verbs with a common prefix for building / modifying datapackages, specifically for datapackages. So provide I think it's a big open question though what base verbs/operations would form an optimal expressive api here... If you ever have a brainstorming session, i'd definitely be interested in participating! |
When using
append()
, the datapackage lists looses its custom class:Created on 2024-03-27 with reprex v2.1.0
This results in
check_package()
warnings like in #194. I assume the way to solve this is by creating aappend.datapackage()
function.To update:
append()
is mentionedThe text was updated successfully, but these errors were encountered: