{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":841517052,"defaultBranch":"main","name":"k6-operator","ownerLogin":"frittentheke","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-08-12T15:04:57.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/13763987?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1724397682.0","currentOid":""},"activityList":{"items":[{"before":"24e21772f958620b026380ed9057b127d5c83ab9","after":"a054bf7aba306b8d1abbc080f842862c0ad6cb43","ref":"refs/heads/failInitOnNonZero_435","pushedAt":"2024-08-23T07:47:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"frittentheke","name":"Christian Rohmann","path":"/frittentheke","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13763987?s=80&v=4"},"commit":{"message":"Combine all initializer commands with && to catch any failing commands\n\nBy running two commands instead of one (the second being the cat | grep), any\nfailures (non-zero exit code) of the first part (containing `k6 inspect`) will\nbe lost and masked away.\n\nBy chaining them all with `&&` the first non-zero RC will fail the whole command\nand return.\n\nFixes: #435","shortMessageHtmlLink":"Combine all initializer commands with &amp;&amp; to catch any failing commands"}},{"before":"33d10eefd63894a4fd8ae67f9c90806c4ed6e4ff","after":"24e21772f958620b026380ed9057b127d5c83ab9","ref":"refs/heads/failInitOnNonZero_435","pushedAt":"2024-08-23T07:31:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"frittentheke","name":"Christian Rohmann","path":"/frittentheke","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13763987?s=80&v=4"},"commit":{"message":"Combine all initializer commands with && to catch any failing commands\n\nBy running two commands instead of one (the second being the cat | grep), any\nfailures (non-zero exit code) of the first part (containing `k6 inspect`) will\nbe lost and masked away.\n\nBy chaining them all with `&&` the first non-zero RC will fail the whole command\nand return.\n\nFixes: #435","shortMessageHtmlLink":"Combine all initializer commands with &amp;&amp; to catch any failing commands"}},{"before":null,"after":"33d10eefd63894a4fd8ae67f9c90806c4ed6e4ff","ref":"refs/heads/failInitOnNonZero_435","pushedAt":"2024-08-23T07:21:22.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"frittentheke","name":"Christian Rohmann","path":"/frittentheke","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13763987?s=80&v=4"},"commit":{"message":"Combine all initializer commands with && to catch any failing commands\n\nBy running two commands instead of one (the second being the cat | grep), any\nfailures (non-zero exit code) of the first part (containing `k6 inspect`) will\nbe lost and masked away.\n\nBy chaining them all with `&&` the first non-zero RC will fail the whole command\nand return.\n\nFixes: #435","shortMessageHtmlLink":"Combine all initializer commands with &amp;&amp; to catch any failing commands"}},{"before":"d302e116e66dcf4d9e9c93a80c552f65fc30656c","after":"1fd1c56387246b0cb1a8dee87713dee899d5d924","ref":"refs/heads/rcInitializer_435","pushedAt":"2024-08-22T12:04:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"frittentheke","name":"Christian Rohmann","path":"/frittentheke","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13763987?s=80&v=4"},"commit":{"message":"Remove fetching of container logs from initializer\n\nFollowing the focus on the exit code of the command using in the initializer job (Pod),\nthis commit removes the fetching of the container log.\n\nThere was only a basic JSON unmarshalling applied with no interpretion of what it contained.\nThis is either covered by `k6 inspect` exiting with rc=0 or should be added to the initializer\njob.\n\nIf further details about the failure reason of the initalizer container was to be required,\nthe source should be the termination message. It could be used to enrich the TestRun CR to provide\na higher level of detail about the failure to the user.\n\n[1] https://kubernetes.io/docs/tasks/debug/debug-application/determine-reason-pod-failure/#customizing-the-termination-message","shortMessageHtmlLink":"Remove fetching of container logs from initializer"}},{"before":"6dde53a0ae4113d902bf38d3be310192fe4c8e7d","after":"d302e116e66dcf4d9e9c93a80c552f65fc30656c","ref":"refs/heads/rcInitializer_435","pushedAt":"2024-08-22T11:54:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"frittentheke","name":"Christian Rohmann","path":"/frittentheke","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13763987?s=80&v=4"},"commit":{"message":"Remove fetching of container logs from initializer\n\nFollowing the focus on the exit code of the command using in the initializer job (Pod),\nthis commit removes the fetching of the container log.\n\nThere was only a basic JSON unmarshalling applied with no interpretion of what it contained.\nThis is either covered by `k6 inspect` exiting with rc=0 or should be added to the initializer\njob.\n\nIf further details about the failure reason needs to be read from the initalizer job, this houdl be the termination message.\n\n[1] https://kubernetes.io/docs/tasks/debug/debug-application/determine-reason-pod-failure/#customizing-the-termination-message","shortMessageHtmlLink":"Remove fetching of container logs from initializer"}},{"before":null,"after":"6dde53a0ae4113d902bf38d3be310192fe4c8e7d","ref":"refs/heads/rcInitializer_435","pushedAt":"2024-08-22T11:41:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"frittentheke","name":"Christian Rohmann","path":"/frittentheke","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13763987?s=80&v=4"},"commit":{"message":"Set TerminationMessagePolicy on Initializer to use logs as fallback\n\nWhile not explicitly used, with the removal of the log fetching from the\nInitializer (Job->Pod->Container) any potential source for verbose information\nabout the error might be lost. The Kubernetes approach to provide more details\nthan the exit code about the reason a container terminated is the termination\nmessage (see [1]).\n\nPer default this message needs to be explictly written to `/dev/termination-log`,\nbut there also is the option to use the last bit of log output as fallback source.\n\n[1] https://kubernetes.io/docs/tasks/debug/debug-application/determine-reason-pod-failure/","shortMessageHtmlLink":"Set TerminationMessagePolicy on Initializer to use logs as fallback"}},{"before":"a4782f2c2b69dec93eecfc68e04cec8228a24534","after":"0ed75725075512d7daf7c638e8ba7c7c3447b4dd","ref":"refs/heads/probeTimeouts_306","pushedAt":"2024-08-13T07:55:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"frittentheke","name":"Christian Rohmann","path":"/frittentheke","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13763987?s=80&v=4"},"commit":{"message":"Increase readiness and liveness probe timeouts, introduce an initial delay\n\nCurrently the default timeout of 1 second and no initial delay is applied\nto the probes of the runner pods. Depending on the startup time this\ncan cause random Pod errors causing a whole TestRun to fail.\n\nAt some point it might also make sense to introduce a startupProbe to cover\nthe longer initial startup time a K6 instance / pod might need instead of ever\nincreasing the runtime liveness and readiness checks.\n\nSince having the Liveness and Readiness checks be just the same makes not much\nsense, as the liveness check fail will cause the container to be restarted,\nthis change also splits up those two tests, to allow for more individual\nconfiguration, be it timers or what is actually checked.\n\nFixes #306\n\nSigned-off-by: Christian Rohmann <christian.rohmann@inovex.de>","shortMessageHtmlLink":"Increase readiness and liveness probe timeouts, introduce an initial …"}},{"before":"4a8902590c6c5fc1dc5f2a83f34d9bacdb155e85","after":"a4782f2c2b69dec93eecfc68e04cec8228a24534","ref":"refs/heads/probeTimeouts_306","pushedAt":"2024-08-13T06:51:28.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"frittentheke","name":"Christian Rohmann","path":"/frittentheke","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13763987?s=80&v=4"},"commit":{"message":"Increase readiness and liveness probe timeouts, introduce an initial delay\n\nCurrently the default timeout of 1 second and no initial delay is applied\nto the probes of the runner pods. Depending on the startup time this\ncan cause random Pod errors causing a whole TestRun to fail.\n\nAt some point it might also make sense to introduce a startupProbe to cover\nthe longer initial startup time a K6 instance / pod might need instead of ever\nincreasing the runtime liveness and readiness checks.\n\nSince having the Liveness and Readiness checks be just the same makes not much\nsense, as the liveness check fail will cause the container to be restarted,\nthis change also splits up those two tests, to allow for more individual\nconfiguration, be it timers or what is actually checked.\n\nFixes #306\n\nSigned-off-by: Christian Rohmann <christian.rohmann@inovex.de>","shortMessageHtmlLink":"Increase readiness and liveness probe timeouts, introduce an initial …"}},{"before":null,"after":"4a8902590c6c5fc1dc5f2a83f34d9bacdb155e85","ref":"refs/heads/probeTimeouts_306","pushedAt":"2024-08-12T15:47:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"frittentheke","name":"Christian Rohmann","path":"/frittentheke","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13763987?s=80&v=4"},"commit":{"message":"Increase readiness and liveness probe timeouts, introduce an initial delay\n\nCurrently the default timeout of 1 second and no initial delay is applied\nto the probes of the runner pods. Depending on the startup time this\ncan cause random Pod errors causing a whole TestRun to fail.\n\nAt some point it might also make sense to introduce a startupProbe to cover\nthe longer initial startup time a K6 instance (Pod) might need instead of every\nincreasing the runtime liveness and readiness checks.\n\nFixes #306\n\nSigned-off-by: Christian Rohmann <christian.rohmann@inovex.de>","shortMessageHtmlLink":"Increase readiness and liveness probe timeouts, introduce an initial …"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOC0yM1QwNzo0Nzo1Ni4wMDAwMDBazwAAAASiFk6n","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOC0yM1QwNzo0Nzo1Ni4wMDAwMDBazwAAAASiFk6n","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOC0xMlQxNTo0NzoyNy4wMDAwMDBazwAAAASYShLW"}},"title":"Activity · frittentheke/k6-operator"}