Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why tag 4.0.0? #126

Open
jmsche opened this issue Jun 3, 2021 · 8 comments
Open

Why tag 4.0.0? #126

jmsche opened this issue Jun 3, 2021 · 8 comments

Comments

@jmsche
Copy link
Contributor

jmsche commented Jun 3, 2021

Hi,

I'm wondering why version 4.0.0 has been tagged with this change? 7e6856f

The version number in the command is only an example, not the real value which will be pulled.

Can this tag/release be reverted please? And removed from packagist as well?

@sguionni
Copy link
Contributor

sguionni commented Jun 3, 2021

@kapil2704 ??

@jmsche
Copy link
Contributor Author

jmsche commented Jun 9, 2021

Hi @kapil2704, could you please stop committing tag change in the command & releasing please?

It does not make any sense to do that.

@sguionni
Copy link
Contributor

sguionni commented Jun 9, 2021

@jmsche i have lost my access to this repository, i don't know what is happening with Froala, but i think you can create a new repository and abandon this one since @kapil2704 don't care about what we are saying

@jmsche
Copy link
Contributor Author

jmsche commented Jun 10, 2021

Thanks for your answer @sguionni, didn't know that. That's unfortunate :/

I'll send an email to Froala support, and fork if no correct actions will be made.

@jroszkiewicz
Copy link

Thanks for your answer @sguionni, didn't know that. That's unfortunate :/

I'll send an email to Froala support, and fork if no correct actions will be made.

And how situation?

@jmsche
Copy link
Contributor Author

jmsche commented Nov 9, 2021

I've sent a bunch of emails.

IIRC they removed the rights to @kapil2704, but I didn't manage to make them understand why I wanted to drop the commits on Github, & tags/releases on Packagist/Github. Problem is, I was never in direct contact with a technical employee, only sales employee.

As Symfony 6 is around the corner (planned for end of November) I think I'll fork the package & clean it up a bit, then make it compatible with Symfony 6.

I'll keep you posted on this issue.

@jroszkiewicz
Copy link

I've sent a bunch of emails.

IIRC they removed the rights to @kapil2704, but I didn't manage to make them understand why I wanted to drop the commits on Github, & tags/releases on Packagist/Github. Problem is, I was never in direct contact with a technical employee, only sales employee.

As Symfony 6 is around the corner (planned for end of November) I think I'll fork the package & clean it up a bit, then make it compatible with Symfony 6.

I'll keep you posted on this issue.

OK, thanks. You have my axe :)

@jmsche
Copy link
Contributor Author

jmsche commented Nov 9, 2021

Hi again,

Here is the fork: https://github.com/leapt/froala-editor-bundle

It requires PHP 8.0+ & Symfony 5.3+. All tags have been reset so the bundle starts at v1 :)

Note that a Flex recipe is on its way as well: symfony/recipes-contrib#1302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants