You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The <FroalaEditor /> component largely depends on interaction with the attached element to initialize the Froala Editor. Technically ember now allows this access by using a modifier. Most of the <FroalaEditor /> code could be moved to a modifier class definition. However, there are some downsides that the component version guards against (mainly ensuring @content is passed in and not used as block content <FroalaEditor>{{this.content}}</FroalaEditor>). Currently this addon uses ember-render-modifiers to gain access to the element. At minimum, I would say both (component and modifier) would be provided by the addon if we do move to a modifier. An alternate and more custom solution is to create a custom modifier manager too, to avoid a dependency on ember-modifier.
The text was updated successfully, but these errors were encountered:
One question to be answered is with extensibility. If the consumer extends the modifier, will the built-in component use the extended modifier? And is that ideal?
Runloop usage is in tests, not components. Render modifiers will be done whenever froala-editor v5 comes out, or ember-addon v2 format is done. Existing issue for this task: #109
The
<FroalaEditor />
component largely depends on interaction with the attachedelement
to initialize the Froala Editor. Technically ember now allows this access by using a modifier. Most of the<FroalaEditor />
code could be moved to a modifier class definition. However, there are some downsides that the component version guards against (mainly ensuring@content
is passed in and not used as block content). Currently this addon uses<FroalaEditor>{{this.content}}</FroalaEditor>
ember-render-modifiers
to gain access to theelement
. At minimum, I would say both (component and modifier) would be provided by the addon if we do move to a modifier. An alternate and more custom solution is to create a custom modifier manager too, to avoid a dependency onember-modifier
.The text was updated successfully, but these errors were encountered: