From dfa46b2b95f405e8703575682ef576286e09f449 Mon Sep 17 00:00:00 2001
From: Friedrich von Never <friedrich@fornever.me>
Date: Wed, 23 Oct 2024 13:07:24 +0300
Subject: [PATCH] More robust testing (#62)

Tests: more robust logging for failed containers, destroy test container before startup
---
 src/VahterBanBot.Tests/ContainerTestBase.fs   | 34 +++++++++++++------
 src/VahterBanBot.Tests/Logging.fs             | 16 +++++++++
 .../VahterBanBot.Tests.fsproj                 |  1 +
 3 files changed, 41 insertions(+), 10 deletions(-)
 create mode 100644 src/VahterBanBot.Tests/Logging.fs

diff --git a/src/VahterBanBot.Tests/ContainerTestBase.fs b/src/VahterBanBot.Tests/ContainerTestBase.fs
index 8fee468..63222d6 100644
--- a/src/VahterBanBot.Tests/ContainerTestBase.fs
+++ b/src/VahterBanBot.Tests/ContainerTestBase.fs
@@ -30,6 +30,7 @@ type VahterTestContainers() =
     let mutable publicConnectionString: string = null
     
     // base image for the app, we'll build exactly how we build it in Azure
+    let buildLogger = StringLogger()
     let image =
         ImageFromDockerfileBuilder()
             .WithDockerfileDirectory(solutionDir, String.Empty)
@@ -39,6 +40,8 @@ type VahterTestContainers() =
             .WithBuildArgument("RESOURCE_REAPER_SESSION_ID", ResourceReaper.DefaultSessionId.ToString("D"))
             // it might speed up the process to not clean up the base image
             .WithCleanUp(false)
+            .WithDeleteIfExists(true)
+            .WithLogger(buildLogger)
             .Build()
 
     // private network for the containers
@@ -113,17 +116,27 @@ type VahterTestContainers() =
             .DependsOn(flywayContainer)
             .WithWaitStrategy(Wait.ForUnixContainer().UntilPortIsAvailable(80))
             .Build()
+            
+    let startContainers() = task {
+        try
+            // start building the image and spin up db at the same time
+            let imageTask = image.CreateAsync()
+            let dbTask = dbContainer.StartAsync()
+
+            // wait for both to finish
+            do! imageTask
+            do! dbTask            
+        with
+        | e ->
+            let logs = buildLogger.ExtractMessages()
+            let errorMessage = "Container startup failure, logs:\n" + if String.IsNullOrWhiteSpace logs then "<no logs provided>" else logs
+            raise <| Exception(errorMessage, e)
+    }
 
     interface IAsyncLifetime with
         member this.InitializeAsync() = task {
             try
-                // start building the image and spin up db at the same time
-                let imageTask = image.CreateAsync()
-                let dbTask = dbContainer.StartAsync()
-
-                // wait for both to finish
-                do! imageTask
-                do! dbTask
+                do! startContainers()
                 publicConnectionString <- $"Server=127.0.0.1;Database=vahter_bot_ban;Port={dbContainer.GetMappedPublicPort(5432)};User Id=vahter_bot_ban_service;Password=vahter_bot_ban_service;Include Error Detail=true;Minimum Pool Size=1;Maximum Pool Size=20;Max Auto Prepare=100;Auto Prepare Min Usages=1;Trust Server Certificate=true;"
                 
                 // initialize DB with the schema, database and a DB user
@@ -158,9 +171,10 @@ type VahterTestContainers() =
                 httpClient.BaseAddress <- uri
                 httpClient.DefaultRequestHeaders.Add("X-Telegram-Bot-Api-Secret-Token", "OUR_SECRET")
             finally
-                let struct (_, err) = appContainer.GetLogsAsync().Result
-                if err <> "" then
-                    failwith err
+                if appContainer.State <> TestcontainersStates.Undefined then
+                    let struct (_stdout, err) = appContainer.GetLogsAsync().Result
+                    if err <> "" then
+                        failwith err
         }
         member this.DisposeAsync() = task {
             // stop all the containers, flyway might be dead already
diff --git a/src/VahterBanBot.Tests/Logging.fs b/src/VahterBanBot.Tests/Logging.fs
new file mode 100644
index 0000000..85c6da3
--- /dev/null
+++ b/src/VahterBanBot.Tests/Logging.fs
@@ -0,0 +1,16 @@
+namespace VahterBanBot.Tests
+
+open System
+open Microsoft.Extensions.Logging
+
+type StringLogger() =
+    let lockObj = obj()
+    let messages = ResizeArray<string>() 
+    interface ILogger with
+        member this.BeginScope _ = null
+        member this.IsEnabled _ = true
+        member this.Log(logLevel, _eventId, state, ex, formatter) =
+            lock lockObj (fun() ->
+                messages.Add($"[{logLevel}] {formatter.Invoke(state, ex)}"))
+
+    member _.ExtractMessages(): string = lock lockObj (fun() -> String.Join("\n", messages))
\ No newline at end of file
diff --git a/src/VahterBanBot.Tests/VahterBanBot.Tests.fsproj b/src/VahterBanBot.Tests/VahterBanBot.Tests.fsproj
index ffa6474..9ed5220 100644
--- a/src/VahterBanBot.Tests/VahterBanBot.Tests.fsproj
+++ b/src/VahterBanBot.Tests/VahterBanBot.Tests.fsproj
@@ -11,6 +11,7 @@
     <ItemGroup>
         <Content Include="test_seed.sql" CopyToOutputDirectory="PreserveNewest" />
         <Compile Include="TgMessageUtils.fs" />
+        <Compile Include="Logging.fs" />
         <Compile Include="ContainerTestBase.fs" />
         <Compile Include="BaseTests.fs" />
         <Compile Include="MessageTests.fs" />