Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling #2

Open
ftsell opened this issue Feb 10, 2021 · 0 comments
Open

Add error handling #2

ftsell opened this issue Feb 10, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ftsell
Copy link
Member

ftsell commented Feb 10, 2021

Currently, any login errors (such as aborted logins or token exchange errors) are completely ignored. This is obviously not good and should be improved.

At least the following error handlers should be implemented:

  • The provided OpenidConfig can be invalid which results in getServiceConfiguration not succeeding
  • Token renewal in renewTokens may fail if the refresh token is expired or the user has revoked the session (logged out)
  • The authorization flow may fail or get aborted which results in doAuthorizationCallback not succeeding because no code is available as query parameter. Instead, the authorization notifier will be called with a non-null error that needs to be handled.
@ftsell ftsell added bug Something isn't working good first issue Good for newcomers labels Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant