Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect self-referencing line directives in generated files #73

Open
miegir opened this issue Mar 27, 2017 · 0 comments
Open

Incorrect self-referencing line directives in generated files #73

miegir opened this issue Mar 27, 2017 · 0 comments
Labels

Comments

@miegir
Copy link

miegir commented Mar 27, 2017

Generated source files (.fs) from both fslex and fsyacc contain line directives. Inserted directives are good when referencing external files (such as source .fsl/.fsy) but are incorrect when referencing the generated file itself. Line number should contain the next line for tooling (such as syntax highlighting, etc.) to work properly.

For example, incorrect line numbers in file.fs that can be generated now are:

# 1 "file.fs" // this is the actual line 1, stating that the next line number is 1 (incorrect)
// some code on line 2

Correct directive that should be generated is:

# 2 "file.fs" // this is the actual line 1, stating that the next line number is 2 (correct)
// some code on line 2
@cartermp cartermp added the bug label Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants