Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3Path Relative_to returns itself #184

Open
AlexBondViv opened this issue Feb 14, 2024 · 4 comments
Open

S3Path Relative_to returns itself #184

AlexBondViv opened this issue Feb 14, 2024 · 4 comments
Assignees
Labels
bug 🐛 Something isn't working
Milestone

Comments

@AlexBondViv
Copy link

AlexBondViv commented Feb 14, 2024

In 0.1.4 S3Path.relative_to would return a path relative to another path

i.e:
UPath("s3://bucket/delta/db/table").relative_to(UPath("s3://bucket/delta/")) == UPath("s3://bucket/db/table")

However in 0.2.0 it seems that relative_to() simply returns itself as UPath("s3://bucket/delta/db/table").relative_to(UPath("s3://bucket/delta/")) returns UPath("s3://bucket/delta/db/table").

@AlexBondViv
Copy link
Author

AlexBondViv commented Feb 14, 2024

I will note that this is still not a relative path as the bucket probably shouldn't be returned either, this is in itself another issue but is already reported in #170

@ap-- ap-- added the bug 🐛 Something isn't working label Feb 18, 2024
@ap-- ap-- self-assigned this Jun 14, 2024
@mmlakera
Copy link

mmlakera commented Aug 5, 2024

Same issue here.

@ap-- ap-- added this to the v0.3.0 milestone Aug 23, 2024
@mmlakera
Copy link

I encountered this issue again, just to find my own answer

@Girmii
Copy link

Girmii commented Dec 3, 2024

Same issue here.

The implementation literally returns the input value.

def relative_to(self, other, /, *_deprecated, walk_up=False):
# use the parent implementation for the ValueError logic
super().relative_to(other, *_deprecated, walk_up=False)
return self

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants