Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with JSDom #56

Open
aendra-rininsland opened this issue Mar 23, 2018 · 0 comments
Open

Does not work with JSDom #56

aendra-rininsland opened this issue Mar 23, 2018 · 0 comments

Comments

@aendra-rininsland
Copy link
Member

aendra-rininsland commented Mar 23, 2018

Currently g-axis makes a lot of calls to SVGElement.getBBox(), which JSDom cannot do anything with because it doesn't do any visual calculations.

There are two ways to resolve this:

1. Explicitly not support JSDom implementations

I'd prefer not to do this if possible because it would mean needing to use really heavy implementations like PhantomJS or Puppeteer on the server, which will reduce adoption of using the charts programmatically within the org.

2. Find a better, non-getBBox() way of calculating sizes

d3-axis seems to manage this fine, it works in JSDom and headless contexts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant