Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

add option to heal #3

Open
shimwell opened this issue Jun 10, 2021 · 9 comments
Open

add option to heal #3

shimwell opened this issue Jun 10, 2021 · 9 comments

Comments

@shimwell
Copy link
Member

the autoheal is sometimes useful so this should be an option

Thanks to @makeclean for the suggestion

@shimwell
Copy link
Member Author

validate vol all is also recommended

@bohmt
Copy link

bohmt commented Sep 16, 2021

Consider also adding:
autoheal analyze vol all

@shimwell
Copy link
Member Author

autoheal catches a few things that validate misses

@shimwell
Copy link
Member Author

shimwell commented Sep 16, 2021

both validate and autoheal this should be run just after loading the cad files

@shimwell
Copy link
Member Author

added to main branch in PR #45

@shimwell
Copy link
Member Author

Looks like the python api command might be slightly different as I just noticed the error

[2021-09-26 22:50:56.891] [error] Unrecognized Keyword: 'autoheal'

ERROR: <stdin>, line 5. Unrecognized Keyword: 'autoheal'
[2021-09-26 22:50:56.891] [error] syntax error (<stdin>, line 6)

@shimwell shimwell reopened this Sep 26, 2021
@LukeLabrie
Copy link
Collaborator

Hey Jonathan, recently started using this one locally. Syntax is healer autoheal volume [ids]

Also on that note, the reason I usually have needed to heal is following a scaling operation. But I just noticed that if I use the .stl format then the units are preserved and there's no need to scale. Is there a reason .stl isn't included as an import option here/any interest in incorporating that?

@shimwell
Copy link
Member Author

Hi Luke, it would be great to see autoheal as an option for the users. Perhaps a boolean flag could be used to control that. Perhaps it could default to current behavior (false).

I've not added an STL import option but that would be nice, I assume Cubit supports it.

PRs welcome.

@LukeLabrie
Copy link
Collaborator

Sounds good. Just submitted a short pr with both stl import and autoheal options. It did not pass the test scripts, but I think it's because this link is no longer valid: https://github.com/fusion-energy/neutronics_workflow/archive/refs/tags/v0.0.2.tar.gz.

I tried both features on local files and it seemed to work ok. Let me know what you think.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants