Full data dump export #312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathandao
reviewed
May 25, 2020
| // Two age groups, _under 50_ and _over 50_ | ||
| age_group: Number(response.age_group) < 50 ? 'under50' : 'over50', | ||
| // Two genders, male and female. Other genders coalesce to male | ||
| gender: response.gender === 'female' ? 'female' : 'male', |
There was a problem hiding this comment.
I guess there is already a discussion for this decision that I was not aware of, but out of curiosity, why not keep other gender as other?
There was a problem hiding this comment.
I'm not aware of any discussion on this (which doesn't mean that such doesn't exist), but I'll just refer you the issue this PR is implementing: #231
Sukupuoli kahtena luokkana (mies, nainen. Muu yhdistetään mies-luokkaan)
Translated:
Gender in two categories (male, female. Other is combined with male-category)
There was a problem hiding this comment.
Ohhh :( Looks like that is something defined by tietosuoja requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231
Adds a new dataset
responses_full.json, which features all responses filtered and mapped as follows:response_id,app_versionandabuse_scoreMap postal codes according to low_population_postal_codes.json
postal_codewe can’t find inpostalcode_city_mappings.jsontimestampage_groupto eitherunder50orover50comparing the incoming age_group to< 50genderto be eithermaleorfemale, other values coalesce tomaleTest locally with the CLI tool:
npm run --silent open-data-cli dump responses_full.json > /tmp/responses_full.jsonSee an online example at https://data.dev.oiretutka.fi/responses_full.json