Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Upgrade BeaconError to allow for 200 response code #262

Open
jrambla opened this issue Jan 29, 2019 · 2 comments
Open

Upgrade BeaconError to allow for 200 response code #262

jrambla opened this issue Jan 29, 2019 · 2 comments
Assignees
@sdelatorrep
Milestone
spec 1.1.1

Comments

@jrambla
Copy link
Collaborator

jrambla commented Jan 29, 2019

Currently, the description of BeaconError is "Beacon-specific error. This should be non-null in exceptional situations only, in which case exists has to be null."
I believe that being precise in the values of attributes is desirable, given the ambiguous meaning of "null" ("no" vs "I don't know").
Thus I'll like to update the description to allow for a 200 response code, while keeping "null" also for retrocompatibility, but "not recommended".
@jrambla
Copy link
Collaborator Author

jrambla commented Jan 29, 2019

Beacon.md should be also updated to better inform on errors or return codes management.

@jrambla jrambla mentioned this issue Jan 29, 2019
Open
@sdelatorrep sdelatorrep added this to the spec 1.1.1 milestone Jan 30, 2019
sdelatorrep added a commit that referenced this issue Jan 30, 2019
@sdelatorrep
Update description of BeaconError and update documentation (issue #262)
3539ab8
@sdelatorrep sdelatorrep self-assigned this Jan 30, 2019
@sdelatorrep
Copy link
Contributor

I created PR #267

sdelatorrep added a commit that referenced this issue Feb 7, 2019
@sdelatorrep
Update description of BeaconError and update documentation (issue #262)
32b3c2d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sdelatorrep sdelatorrep

Labels
None yet
Projects
None yet
Milestone
spec 1.1.1
Development

No branches or pull requests
2 participants
@jrambla @sdelatorrep