Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Change booleans to enums #869

Open
david4096 opened this issue Mar 24, 2017 · 0 comments
Open

Change booleans to enums #869

david4096 opened this issue Mar 24, 2017 · 0 comments
Labels

Comments

@david4096
Copy link
Member

For any field where the default boolean should not be considered false, we should offer an enum that states "no value selected" or "null" that is the default. This is currently a bug that makes documents incorrect when the values aren't known, since False is assumed.

For example, improper_placement on an alignment. https://github.com/ga4gh/ga4gh-schemas/blob/master/src/main/proto/ga4gh/reads.proto#L140

@david4096 david4096 added the bug label Mar 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant