Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error display with next branch? #123

Open
zaynv opened this issue Apr 5, 2017 · 1 comment
Open

No error display with next branch? #123

zaynv opened this issue Apr 5, 2017 · 1 comment

Comments

@zaynv
Copy link

zaynv commented Apr 5, 2017

When using the next branch of the boilerplate, I get no error display on the page when I add a syntax error to my component (although the error does show up in the console). When using the master branch, I do not have this issue. Was error reporting removed when switching to the next branch or is the branch not ready for use yet? Or am I just doing something wrong?

Steps to reproduce:

  1. Go to the next branch, click the Clone or download button, and then click Download ZIP.
  2. After unzipping the contents, run npm install, and then npm start.
  3. Go to the Counter.js file and change <h2>Counter: {this.state.counter}</h2> to <h2Counter: {this.state.counter}</h2>

As you can see, the error shows up in the console but there is no feedback on the page itself:

screen shot 2017-04-05 at 2 04 10 pm

When using the boilerplate from the master branch, I DO get feedback:

screen shot 2017-04-05 at 2 06 06 pm

Please let me know if I can provide any more information. Thanks very much.

@zaynv
Copy link
Author

zaynv commented Apr 6, 2017

It looks like I just needed to add overlay: true to the devServer options in webpack.config.js. Should this be in there by default? If not, feel free to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant