Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter Conversion from ODS to Xarray #318

Open
allen-adastra opened this issue Aug 28, 2024 · 2 comments
Open

Smarter Conversion from ODS to Xarray #318

allen-adastra opened this issue Aug 28, 2024 · 2 comments

Comments

@allen-adastra
Copy link

Hello, thank you for this package!

I recently tried using the .dataset() method to convert an ODS object to a xr.Dataset.

I noticed the resulting object is not necessarily the most desirable.

A couple of notes:

  1. It seems to create a new time dimension for every channel
  2. It might make sense to have "channel" be a dimension
  3. Quantities that perhaps are more appropraite as metadata are data variables

Wondering if there are thoughts/recs on developing a generic approach to improving the translation?

image

@orso82
Copy link
Member

orso82 commented Aug 29, 2024

@allen-adastra I don't think the xarray representation is actively used anywhere. Absolutely, feel free to improve on it!!! If you do, please run the regression tests as you develop, to make sure the internals of OMAS keep working.

Copy link

This issue has not seen any activity in the past 60 days. It is now marked as stale and will be closed in 7 days if no further activity is registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants