Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashes without Refdata on CVMFS #439

Closed
mapk-amazon opened this issue Aug 18, 2023 · 1 comment · Fixed by #440 · May be fixed by #441
Closed

Crashes without Refdata on CVMFS #439

mapk-amazon opened this issue Aug 18, 2023 · 1 comment · Fixed by #440 · May be fixed by #441

Comments

@mapk-amazon
Copy link
Contributor

I currently try to deploy the helm chart without reference data. When I do, https://github.com/galaxyproject/galaxy-helm/blob/master/galaxy/templates/hook-cvmfs-fix.yaml this hook starts up and continues to wait for some cvmfs pods (ironically to kill them). As there is no pod, it runs indefinitely.

refdata.enabled: false
refdata.type: s3sci
s3csi.deploy: false
cvmfs.deploy: false
cvmfs.enabled: false

Expected behaviour:
If no cvmfs is used, then the pod for fixing cvmfs does not run. Alternatively after no pod is found for 1-2 minutes, the pod finishes up.

Thank you!
ksuderman added a commit that referenced this issue Aug 18, 2023
@ksuderman
Remove the CVMFS fix (hack). Closes #439
f285b1b
This was referenced Aug 18, 2023
Merged
Open
@ksuderman
Copy link
Contributor

Thanks for the report. That was a hack we introduced to work around a problem with the CVMFS CSI driver and is hopefully no longer needed. We should either:

  1. Remove the hook-cvmfs-fix.yaml template (Remove CVMFS fix #441), or
  2. Add a guard so the hook only executes when refdata.enabled = true and refdata.type = cvmfs (Only execute the hook-cvmfs-fix if CVMFS is actually enabled. #440)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ksuderman @mapk-amazon