Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

Faulty path detection for involucro #110

Open
mbargull opened this issue May 6, 2018 · 0 comments · May be fixed by #111
Open

Faulty path detection for involucro #110

mbargull opened this issue May 6, 2018 · 0 comments · May be fixed by #111

Comments

@mbargull
Copy link
Contributor

mbargull commented May 6, 2018

mulled always downloads involucro unless it is in the current working directory or --involucro-path is provided. It fails to detect if involucro is available via PATH since https://github.com/galaxyproject/galaxy-lib/blob/18.5.7/galaxy/tools/deps/mulled/mulled_build.py#L288 does not inspect PATH.
In Python >=3.3 this could be solved by using shutil.which.
For Python 2 compatibility, there are some packages, e.g., backports.shutil_which or whichcraft, that backport the functionality from https://github.com/python/cpython/blob/3.7/Lib/shutil.py#L1109-L1169.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhance the installation detection of involucro galaxyproject/galaxy-lib
1 participant
@mbargull