Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release script if multiple bug fixes subheadings in changelog #15

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 2, 2024

Fixes

Traceback (most recent call last):
  File "/Users/mvandenb/src/galaxy/.venv/bin/galaxy-release-util", line 8, in <module>
    sys.exit(cli())
             ^^^^^
  File "/Users/mvandenb/src/galaxy/.venv/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mvandenb/src/galaxy/.venv/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/Users/mvandenb/src/galaxy/.venv/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mvandenb/src/galaxy/.venv/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mvandenb/src/galaxy/.venv/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mvandenb/src/galaxy/.venv/lib/python3.11/site-packages/galaxy_release_util/point_release.py", line 638, in create_point_release
    package = read_package(package_path)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mvandenb/src/galaxy/.venv/lib/python3.11/site-packages/galaxy_release_util/point_release.py", line 159, in read_package
    package.package_history = parse_changelog(package)
                              ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mvandenb/src/galaxy/.venv/lib/python3.11/site-packages/galaxy_release_util/point_release.py", line 203, in parse_changelog
    assert isinstance(section_changelog_item, docutils.nodes.bullet_list)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

@mvdbeek mvdbeek force-pushed the fix_release_creation_if_multiple_bug_fixes_sections_in_changelog branch from fe8d81d to e6b6371 Compare May 2, 2024 12:08
@mvdbeek mvdbeek merged commit 5ae8784 into main May 2, 2024
10 checks passed
@jdavcs
Copy link
Member

jdavcs commented May 2, 2024

@mvdbeek I had that fixed locally and never pushed - sorry about that! :)
My fix was this:

assert isinstance(section_changelog_item, docutils.nodes.bullet_list) or isinstance(section_changelog_item, docutils.nodes.system_message)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants