Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing sign posts remote builds as the solution to large build errors. #148

Open
frostebite opened this issue May 1, 2021 · 7 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@frostebite
Copy link
Member

frostebite commented May 1, 2021

Something should more clearly state in the GitHub docs that larger repository sizes will require either a self-hosted runner or remote builder.

Perhaps we should catch the error and output a link to the docs also.

@webbertakken
Copy link
Member

I do not understand the description right now @frostebite.

@frostebite
Copy link
Member Author

frostebite commented May 2, 2021

Sorry about that. Updated the description. Let me know if that's any clearer.

@webbertakken
Copy link
Member

Gotcha!

Are we talking about the 5GB cache limitation in GitHub for project/Library here or about disk space usage of 18GB(~60GB)?

@frostebite frostebite added the documentation Improvements or additions to documentation label May 2, 2021
@frostebite
Copy link
Member Author

This is referring to the fact that currently a user exploring the documentation about game.ci/github-builds will not be warned ahead of trying to run their project that maximum disc space is available. This will potentially lead to a new user first configuring the default game.ci/unity-builder, running out of space and then reactively discovering game.ci/remote-builder.

We should try and enable the user to understand this consideration early if possible and help them to avoid wasting time.

So this is referring to disc space usage. Not cache limitations.

@frostebite
Copy link
Member Author

Is there somewhere on the getting started page we could sign post users to "cloud runner" / remote builder that you'd agree is fitting for that page?

@webbertakken

"If you have a project larger than x GB, you may want to take a look at Cloud Runner." Somewhere for example.

@webbertakken
Copy link
Member

Good idea.

My suggestion would be to make a short section following the Overall steps section where you'd quickly choose one of the two just for the mental model.

In the cloud builder section we could explain when exactly to choose it, in more detail.

As for the criteria. I believe the optimum workflow differs on a case by case basis. My suggestion would explain the bottleneck, and giving people the choice of which runner to choose.

Perhaps something like this?

GitHub's cache action allows for a maximum per-cache size of 5GB, after which the cache may become less effective. If you face any bottlenecks, we would advise to switch to cloud runner.

@frostebite
Copy link
Member Author

Great suggestion, will seek to include this in the documentation update.

@frostebite frostebite linked a pull request Apr 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants