Upgrading to builder@v3 broke iOS builds

[mikekhristo]

Bug description

After upgrading to Unity 2022.3.9f1 we had to upgrade to unity-builder@v3 from v2. In doing so, builds started failing in the github workflow.

2023-09-13T05:02:58.7374030Z /Users/runner/work/_actions/game-ci/unity-builder/v3/webpack:/unity-builder/lib/model/exec-with-error-check.js:16
2023-09-13T05:02:58.7374970Z             throw new Error(`There was an error building the project. Please read the logs for details.`);

The Build Results show that while there was 1 error, the build actually suceeded:

2023-09-13T05:02:47.9154000Z ###########################
2023-09-13T05:02:47.9155020Z #      Build results      #
2023-09-13T05:02:47.9156470Z ###########################
2023-09-13T05:02:47.9158390Z 
2023-09-13T05:02:47.9158920Z Duration: 00:19:36.3575024
2023-09-13T05:02:47.9160530Z Warnings: 175
2023-09-13T05:02:47.9161560Z Errors: 1
2023-09-13T05:02:47.9162070Z Size: 1658650774 bytes
2023-09-13T05:02:47.9162340Z 
2023-09-13T05:02:47.9162350Z 
2023-09-13T05:02:47.9162530Z Build succeeded!

There is 1 Exit Code 1 in the log output related to verifying the license. However, you can see that it was able to identify an active Pro license via serial number.

2023-09-13T04:30:52.8443670Z [Licensing::Client] Error: Code 1 while verifying Licensing Client signature (process Id: 2878, path: "/Applications/Unity/Hub/Editor/2022.3.9f1/Unity.app/Contents/Frameworks/UnityLicensingClient.app/Contents/MacOS/Unity.Licensing.Client")
2023-09-13T04:30:52.8444810Z [Licensing::Module] Error: LicensingClient has failed validation; ignoring
2023-09-13T04:30:52.9150380Z [Licensing::Client] Handshaking with LicensingClient:
2023-09-13T04:30:52.9152020Z   Version:                 1.13.1+ca5f299
2023-09-13T04:30:52.9153460Z   Session Id:              f54d476e959547ba85e2435ca9303025
2023-09-13T04:30:52.9157890Z   Correlation Id:          11dba8cd44977f4ed2490be529ace13b
2023-09-13T04:30:52.9159640Z   External correlation Id: 328742284493430721
2023-09-13T04:30:52.9160900Z   Machine Id:              76xPhwp+4YDfp8s5XYWnxN7z45Q=
2023-09-13T04:30:52.9162720Z [Licensing::Module] Successfully connected to LicensingClient on channel: "LicenseClient-runner" (connect: 0.99s, validation: 0.07s, handshake: 0.04s)
2023-09-13T04:30:52.9164660Z [Licensing::IpcConnector] Successfully connected to the License Notification on channel: "LicenseClient-runner-notifications" at "2023-09-13T04:30:52.914642Z"
2023-09-13T04:30:52.9167070Z [Licensing::Module] Connected to LicensingClient (PId: 2878, launch time: 0.00, total connection time: 1.09s)
2023-09-13T04:30:52.9351980Z [Licensing::Client] Successfully updated the access token
2023-09-13T04:30:52.9353550Z [Licensing::Module] Successfully updated the access token d9d4fJGhBH...
2023-09-13T04:30:54.2331250Z [Licensing::Client] Successfully updated license
2023-09-13T04:30:54.2528740Z [Licensing::Client] Successfully resolved entitlements
2023-09-13T04:30:54.2533700Z [Licensing::Module] Serial number assigned to: "SC-VB3S-GAKJ-GDV4-XXXX-XXXX"
2023-09-13T04:30:54.2535440Z Pro License: YES

So we have a scenario where the build succeeded, the error doesn't seem to be a fatal error, but the builder aborts anyway.

Happy to share the full output privately if anyone would like. Thanks!

[GabLeRoux]

See #576

[AndrewKahr]

Try updating to v4 and see if this is solved now