Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Effects #51

Open
RobDavenport opened this issue Sep 5, 2022 · 2 comments
Open

Audio Effects #51

RobDavenport opened this issue Sep 5, 2022 · 2 comments
Labels
Audio Related to the Audio or Sound Engine crates. Discussion Discussions and non-concrete issues. enhancement New feature or request help wanted Extra attention is needed

Comments

@RobDavenport
Copy link
Member

Lots of retro consoles had built-in features, like reverb, echo, delay, as well as note-level effects like slide or arpeggiators.

I think it would be good to discuss some potential approaches and some effects we could start developing 2-3 effects as a proof-of-concept. The Phrase struct already has the array of three Option<Effect> to use, so we can easily plug into there.

@RobDavenport RobDavenport added enhancement New feature or request help wanted Extra attention is needed Audio Related to the Audio or Sound Engine crates. Discussion Discussions and non-concrete issues. labels Sep 5, 2022
@RobDavenport RobDavenport pinned this issue Sep 5, 2022
@RobDavenport RobDavenport unpinned this issue Sep 13, 2022
@VegaDeftwing
Copy link

I would think starting with a tremolo effect would be a good start, given the extreme simplicity. Reverb has the potential to back you into a weird corner for performance, as most reverbs use a crazy amount of CPU horse power or just sound pretty awful.

For note effects, I think some sort of DSL could be neat. See https://nestup.cutelab.nyc or https://100r.co/site/orca.html for inspiration, though something dramatically more traditional would probably be better.

@RobDavenport
Copy link
Member Author

RobDavenport commented Sep 27, 2022

@VegaDeftwing thanks for your suggestion! I have heard about the issues with reverb before 😂 so I agree. I would like to prioritize, as you mentioned, simpler effects like the tremolo, slide, and whatever that awesome chip-tune arpeggiated chords effect.

As for the DSL suggestion, I agree it would be cool, but seems a bit too niche currently.

Edit: This is the effect I'm talking about: https://www.youtube.com/watch?v=4HWHneafZ8w

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Related to the Audio or Sound Engine crates. Discussion Discussions and non-concrete issues. enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants